[Mesa-dev] [PATCH kmscube] drm-common.h: forward-declare needed structs

Emil Velikov emil.l.velikov at gmail.com
Tue Mar 14 12:13:07 UTC 2017


On 13 March 2017 at 19:24, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 13 March 2017 at 17:14, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
>> drm-common.h:63:49: warning: ‘struct egl’ declared inside parameter list will not be
>> visible outside of this definition or declaration
>>   int (*run)(const struct gbm *gbm, const struct egl *egl);
>>                                                  ^~~
>> drm-common.h:63:26: warning: ‘struct gbm’ declared inside parameter list will not be
>> visible outside of this definition or declaration
>>   int (*run)(const struct gbm *gbm, const struct egl *egl);
>>                           ^~~
>>
> Was going to say "how ?" only to notice that WARN_CFLAGS is unused.
> Might as well cut it down to -Wall -Wextra and make sure it's used ?
>
Actually I went ahead and did these last night. Patches coming in a minute.

-Emil


More information about the mesa-dev mailing list