[Mesa-dev] [PATCH 05/12] anv/query: Let 32-bit values wrap

Jason Ekstrand jason at jlekstrand.net
Thu Mar 16 00:03:09 UTC 2017


>From the Vulkan 1.0.39 Specification:

   "If VK_QUERY_RESULT_64_BIT is not set and the result overflows a
   32-bit value, the value may either wrap or saturate."

So we can either clamp or wrap.  Wrapping is both easier and what the
user gets if they use vkCmdCopyQueryPoolResults and we should be
consistent.  We could make vkCmdCopyQueryPoolResults clamp but it's
annoying and ends up burning extra batch for something the spec clearly
doesn't require.
---
 src/intel/vulkan/genX_query.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/intel/vulkan/genX_query.c b/src/intel/vulkan/genX_query.c
index 2429386..a311b4b 100644
--- a/src/intel/vulkan/genX_query.c
+++ b/src/intel/vulkan/genX_query.c
@@ -181,8 +181,6 @@ VkResult genX(GetQueryPoolResults)(
             dst[1] = slot[firstQuery + i].available;
       } else {
          uint32_t *dst = pData;
-         if (result > UINT32_MAX)
-            result = UINT32_MAX;
          if (write_results)
             dst[0] = result;
          if (flags & VK_QUERY_RESULT_WITH_AVAILABILITY_BIT)
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list