[Mesa-dev] [PATCH 2/4] aubinator: Delete redundant NULL check.
Kenneth Graunke
kenneth at whitecape.org
Thu Mar 16 03:01:59 UTC 2017
handle_struct_decode() is just a wrapper around decode_structure()
with a NULL check. But the only caller already does that NULL check.
So, just use decode_structure() directly.
---
src/intel/tools/aubinator.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c
index 139637cfefa..676358f57a1 100644
--- a/src/intel/tools/aubinator.c
+++ b/src/intel/tools/aubinator.c
@@ -162,15 +162,6 @@ decode_structure(struct gen_spec *spec, struct gen_group *strct,
}
static void
-handle_struct_decode(struct gen_spec *spec, char *struct_name, uint32_t *p)
-{
- if (struct_name == NULL)
- return;
- struct gen_group *struct_val = gen_spec_find_struct(spec, struct_name);
- decode_structure(spec, struct_val, p);
-}
-
-static void
dump_binding_table(struct gen_spec *spec, uint32_t offset)
{
uint32_t *pointers, i;
@@ -802,7 +793,9 @@ parse_commands(struct gen_spec *spec, uint32_t *cmds, int size, int engine)
if (token != NULL) {
printf("0x%08"PRIx64": 0x%08x : Dword %d\n",
offset + 4 * idx, p[idx], idx);
- handle_struct_decode(spec,token, &p[idx]);
+ struct gen_group *struct_val =
+ gen_spec_find_struct(spec, token);
+ decode_structure(spec, struct_val, &p[idx]);
token = NULL;
}
}
--
2.12.0
More information about the mesa-dev
mailing list