[Mesa-dev] [PATCH v2] android: fix segfault within swap_buffers

[Emil Velikov]

On 16 March 2017 at 08:55, Tapani Pälli <tapani.palli at intel.com> wrote:
> Function droid_swap_buffers may get called without dri2_surf->buffer set,
> in these cases we don't have a back buffer set either. Patch fixes segfault
> seen with 3DMark that uses android.opengl.GLSurfaceView for rendering it's UI.
>
> backtrace:
>    #00 pc 00013f88  /system/lib/egl/libGLES_mesa.so (droid_swap_buffers+104)
>    #01 pc 000117b2  /system/lib/egl/libGLES_mesa.so (dri2_swap_buffers+50)
>    #02 pc 000058b2  /system/lib/egl/libGLES_mesa.so (eglSwapBuffers+386)
>    #03 pc 00011329  /system/lib/libEGL.so (eglSwapBuffersWithDamageKHR+553)
>    #04 pc 000118e7  /system/lib/libEGL.so (eglSwapBuffers+55)
>    #05 pc 000754dc  /system/lib/libandroid_runtime.so
>
> v2: do like other backends, call get_back_bo (Emil Velikov)
>
Thank you.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

In the future we can hold the backends and track down exactly why/how
but for now this should do it.

-Emil