[Mesa-dev] [PATCH 0/6] Fixes a few radeon issues found by Coverity

Julien Isorce julien.isorce at gmail.com
Thu Mar 16 14:25:22 UTC 2017


CID 1399479: medium
CID 1237295: medium
CID 1313492: medium
CID 1354483: medium
CID 1250588: high
CID 715739:  high

It is all more cosmetic than anything but worth to add some more checks.
To Emil: thx for your reply about "question about container_of". Here is
a cosmetic patch for it.

https://scan.coverity.com/projects/mesa/view_defects

Julien Isorce (6):
  radeon: initialize hole variable before calling container_of
  r600_shader.c: check validity of the value returned by
    eg_get_interpolator_index
  si_pipe: do not dereference sscreen before checking if it is NULL.
  radeon_drm_bo: explicitly check return value of drmCommandWriteRead
  si_blit: check zstex nullity
  si_descriptor: move velems nullity check before dereference

 src/gallium/drivers/r600/r600_shader.c        |  6 ++++--
 src/gallium/drivers/radeonsi/si_blit.c        |  6 ++++--
 src/gallium/drivers/radeonsi/si_descriptors.c | 15 +++++++++++----
 src/gallium/drivers/radeonsi/si_pipe.c        | 12 ++++++------
 src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 11 ++++++++---
 5 files changed, 33 insertions(+), 17 deletions(-)

-- 
2.7.4



More information about the mesa-dev mailing list