[Mesa-dev] [PATCH 00/23] nir/i965: Return progress from NIR passes

[Jason Ekstrand]

On Thu, Mar 16, 2017 at 2:17 PM, Matt Turner <mattst88 at gmail.com> wrote:

> I started to add support to NIR for something like INTEL_DEBUG=optimizer,
> but
> then realized that a bunch of NIR passes didn't even return progress.
>
> After fixing that, I realized that a bunch of NIR passes didn't preserve
> metadata.
>
> Sigh.
>

:(

I think I may have seen a few more as I was reviewing but they're not
passes we're calling.

I also found an issue in patch 19 so I think that one needs a bit of work.

1-18 and 20-23 are

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

I can't say I read them super-carefully so it's somewhere between an ack
and a review (probably closer to the review side) but I didn't see anything
amiss other than the issue on 19.

--Jason


> I have not tested radv, freedreno, or vc4, but I think that since I did not
> replace their OPT_V/NIR_PASS_V everything should work just the same, and
> allow
> them to transition at their leisure.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170316/91f3a0d9/attachment-0001.html>