[Mesa-dev] [PATCH v2 00/23] Fix the broken^Wfragile glsl tests

Emil Velikov emil.l.velikov at gmail.com
Fri Mar 17 13:19:26 UTC 2017


Hi all

A few weeks ago I've notice that the glsl tests have not been executed 
for 2+years and attempted to resolve that. Namely:

 - make distcheck - generates and executes 0 (yes zero)  tests
 - out of tree make check is broken - either generates or executes 0 
tests, or fails since the glsl_compiler name/path is hardcoded.
 - manual invocation of the test, requires you to be in dirname

Good news is that nothing has regressed in the glsl codebase.

If anyone is interested in rewriting the [rather crazily designed] the 
lot, please do. Your help will be appreciated.

Emil

Emil Velikov (23):
  glsl/tests: automake: cleanup all artefacts during clean-local
  glsl: automake: export abs_builddir for the tests
  glsl/tests/warnings-test: error out if glsl_compiler is missing
  glsl/tests/warnings-test: add fallback srcdir/abs_builddir defines
  glsl/tests/warnings-test: correctly manage srcdir/builddir
  glsl/tests/warnings-test: error if zero tests were executed
  glsl/tests/warnings-test: print only the test basename
  glsl/tests/optimisation-test: make sure that $PYTHON2 is set/available
  glsl/tests/optimization-test: add fallback srcdir/abs_builddir defines
  glsl/tests/optimization-test: correctly set compare_ir
  glsl/tests/optimisation-test: ensure that compare_ir is available
  glsl/tests/optimization-test: correctly manage srcdir/builddir
  glsl/tests/optimization-test: error out if we fail to generate any
    tests
  glsl/tests/optimization-test: pass glsl_test as argument
  glsl/tests/optimization-test: error if zero tests were executed
  glsl/tests/optimization-test: print only the test basedir/name
  glsl/tests/optimization-test: 'echo' only folders which has generators
  glcpp/tests/glcpp-test: set srcdir/abs_builddir variables
  glcpp/tests/glcpp-test: print only the test basename
  glcpp/tests/glcpp-test: error out if we cannot find any tests
  glcpp/tests: update testname in help string
  glcpp/tests/glcpp-test-cr-lf: correctly set/use srcdir/abs_builddir
  glcpp/tests/glcpp-test-cr-lf: error out if we cannot find any tests

 src/compiler/Makefile.glsl.am                      |  8 ++-
 src/compiler/glsl/glcpp/tests/glcpp-test-cr-lf.sh  | 38 ++++++++-----
 src/compiler/glsl/glcpp/tests/glcpp-test.sh        | 34 ++++++++----
 .../glsl/tests/lower_jumps/create_test_cases.py    | 20 ++++++-
 src/compiler/glsl/tests/optimization-test.sh       | 64 +++++++++++++++++++---
 src/compiler/glsl/tests/warnings-test.sh           | 39 +++++++++++--
 6 files changed, 158 insertions(+), 45 deletions(-)

-- 
2.11.1



More information about the mesa-dev mailing list