[Mesa-dev] [PATCH v2 00/23] Fix the broken^Wfragile glsl tests

Kenneth Graunke kenneth at whitecape.org
Fri Mar 17 18:30:22 UTC 2017


On Friday, March 17, 2017 6:19:26 AM PDT Emil Velikov wrote:
> Hi all
> 
> A few weeks ago I've notice that the glsl tests have not been executed 
> for 2+years and attempted to resolve that. Namely:
> 
>  - make distcheck - generates and executes 0 (yes zero)  tests
>  - out of tree make check is broken - either generates or executes 0 
> tests, or fails since the glsl_compiler name/path is hardcoded.
>  - manual invocation of the test, requires you to be in dirname
> 
> Good news is that nothing has regressed in the glsl codebase.
> 
> If anyone is interested in rewriting the [rather crazily designed] the 
> lot, please do. Your help will be appreciated.
> 
> Emil

Thank you for fixing up the glcpp scripts to be easier to run!
Those tests are very valuable when working on the preprocessor.

The rest I don't care about, and I doubt anyone else cares that much
either, so I'm just going to give you a giant:

Acked-by: Kenneth Graunke <kenneth at whitecape.org>

without even really reading the series. :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170317/16cb2983/attachment-0001.sig>


More information about the mesa-dev mailing list