[Mesa-dev] [PATCH 1/3] intel: remove blorp_alloc_dynamic_state unused argument

[Emil Velikov]

On 17 March 2017 at 19:05, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On Fri, Mar 17, 2017 at 10:10 AM, Emil Velikov <emil.l.velikov at gmail.com>
> wrote:
>>
>> On 17 March 2017 at 16:55, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> > From: Emil Velikov <emil.velikov at collabora.com>
>> >
>> > The enum aub_state_struct_type type is a seeming left over from the
>> > i965 days. Since we don't use we can safely drop it.
>> >
>> > As a nice side-effect the only libdrm_intel requirement in src/intel
>> > [outside of tools/aubinator] - include intel_aub.h can now be removed.
>> > And with next commit we'll remove the dependency in the build system(s).
>> >
>> > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> > ---
>> >  src/intel/blorp/blorp_genX_exec.h  | 12 +++++-------
>> >  src/intel/vulkan/genX_blorp_exec.c |  1 -
>> >  2 files changed, 5 insertions(+), 8 deletions(-)
>> >
>> Hmm actually this won't fly since we have the declaration in blorp,
>> and two distinct definitions - anv and i965.
>> With the latter actually using the type to annotate appropriately.
>>
>> We could drop all that, but I'm not sure how many/often people use
>> DEBUG_BATCH/do_batch_dump.
>> So unless someone voices for the removal of do_batch_dump (and
>> friends) this series goes in the bin :-\
>
>
> Put it on the shelf rather than the bin please. :-)  I think we're probably
> going to be deleting the AUB annotation stuff from i965 before too much
> longer.

/me sheds a tear of joy.

Not sure if you saw - last night I've purged a lot of the legacy
libdrm_intel API, with the intel_decode functionality and aub (stubs)
being amongst them. I could would not mind giving it a bit more polish
alongside a couple of scripts to make fixing mesa/others easier ;-)

-Emil