[Mesa-dev] [PATCH v2 03/23] glsl/tests/warnings-test: error out if glsl_compiler is missing

Emil Velikov emil.l.velikov at gmail.com
Sun Mar 19 14:54:45 UTC 2017


On 19 March 2017 at 13:26, Eric Engestrom <eric at engestrom.ch> wrote:
> On Friday, 2017-03-17 13:19:29 +0000, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> ... or non-executable, in particular.
>
> You'll want to add `-x` if you want to test that too.
>
Since I've dropped the execute bit I should have dropped this line as well.

>>
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>>  src/compiler/glsl/tests/warnings-test.sh | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/src/compiler/glsl/tests/warnings-test.sh b/src/compiler/glsl/tests/warnings-test.sh
>> index 6a52d4064f8..50d760511c0 100755
>> --- a/src/compiler/glsl/tests/warnings-test.sh
>> +++ b/src/compiler/glsl/tests/warnings-test.sh
>> @@ -6,6 +6,11 @@ compiler=./glsl_compiler
>>  total=0
>>  pass=0
>>
>> +if [ ! -e "$compiler" ]; then
>
> `-f` here too?
>
Indeed. Thanks

-Emil


More information about the mesa-dev mailing list