[Mesa-dev] [PATCH] anv: add the main include directory back

[Emil Velikov]

On 19 March 2017 at 21:48, Grazvydas Ignotas <notasas at gmail.com> wrote:
> On Sun, Mar 19, 2017 at 11:27 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 19 March 2017 at 16:32, Grazvydas Ignotas <notasas at gmail.com> wrote:
>>
>>> With that, it's picking the earlier installed
>>> /opt/xorg/include/vulkan/vulkan_intel.h instead of
>>> ../../include/vulkan/vulkan_intel.h , and that one has:
>>>
>>> #include "vulkan.h"
>>>
>> I'm wondering if that one should be <vulkan/vulkan.h> although I'm not
>> an expert why we have a vulkan_intel.h in the first place.
>> Let's stick with Jason's suggestion and use the in-tree headers -
>> please move AM_CPPFLAGS at the top of VULKAN_CPPFLAGS.
>
> In my setup AM_CPPFLAGS also contains -I/opt/xorg/include , so that
> will prefer the install location over all others from VULKAN_CPPFLAGS,
> which feels like it may lead to similar problem again in future?
>
Thanks for bearing with my silly moments :-)

I should have said - please move the include to the top and add the
extra include with the missing "/vulkan" suffix.
Either once or two commits - up-to you really.

There's something really odd on my end - no idea how things built,
considering the "vulkan.h" vs <vulkan/vulkan.h> as originally I
though.
In either case I think Jason has a point - we'd want to use the
in-tree headers prior to anything else.

Thanks again !
Emil