[Mesa-dev] [PATCH] Vulkan: Solve the vkCmdClearColorImage crash issue

[Xu, Randy]

> -----Original Message-----
> From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On
> Behalf Of Xu, Randy
> Sent: Monday, March 20, 2017 2:41 PM
> To: Palli, Tapani <tapani.palli at intel.com>; Emil Velikov
> <emil.l.velikov at gmail.com>; Landwerlin, Lionel G
> <lionel.g.landwerlin at intel.com>
> Cc: ML mesa-dev <mesa-dev at lists.freedesktop.org>; Xu at freedesktop.org
> Subject: Re: [Mesa-dev] [PATCH] Vulkan: Solve the vkCmdClearColorImage
> crash issue
> 
> 
> 
> 
> Thanks,
> Randy
> 
> 
> > -----Original Message-----
> > From: Palli, Tapani
> > Sent: Monday, March 20, 2017 2:34 PM
> > To: Xu, Randy <randy.xu at intel.com>; Emil Velikov
> > <emil.l.velikov at gmail.com>; Landwerlin, Lionel G
> > <lionel.g.landwerlin at intel.com>
> > Cc: ML mesa-dev <mesa-dev at lists.freedesktop.org>; Xu at freedesktop.org
> > Subject: Re: [Mesa-dev] [PATCH] Vulkan: Solve the vkCmdClearColorImage
> > crash issue
> >
> >
> >
> > On 03/20/2017 02:35 AM, Xu, Randy wrote:
> > >
> > >> -----Original Message-----
> > >> From: Emil Velikov [mailto:emil.l.velikov at gmail.com]
> > >> Sent: Sunday, March 19, 2017 11:39 PM
> > >> To: Landwerlin, Lionel G <lionel.g.landwerlin at intel.com>
> > >> Cc: Xu, Randy <randy.xu at intel.com>; ML mesa-dev <mesa-
> > >> dev at lists.freedesktop.org>; Xu at freedesktop.org
> > >> Subject: Re: [Mesa-dev] [PATCH] Vulkan: Solve the
> > >> vkCmdClearColorImage crash issue
> > >>
> > >> On 18 March 2017 at 12:21, Lionel Landwerlin
> > >> <lionel.g.landwerlin at intel.com> wrote:
> > >>> Also, we want this in Cc for stable :)
> > >>>
> > >> That would be a good idea, imho.
> > >>
> > >> Randy, for future patches please check with `git log' for the patch
> > >> prefix -
> > >> "anv: " is the one you want here.
> > > Sure, I will follow this rule, should I revise the recent two patches?
> >
> > I pushed your first patch in and changed the prefix as anv/genX for that
> one.
> >
> > As for the second one, I'm not sure if all layerCount accesses should
> > be changed at once or is it ok to push this one separately (?)
> 
> Thanks, Tapani
> I am checking other layerCount access, and plan to submit another patch
> soon.
> But for vkCmdClearColorImage crash, this one is enough.

Sorry, please wait a minute, I will submit a new patch set, which will handle another case in anv_CmdClearDepthStencilImage also.
The VK_REMAINING_ARRAY_LAYERS only occurs in VkImageSubresourceRange. We don’t need call anv_get_layerCount for VkImageSubresourceLayers

> 
> >
> >
> > >
> > >> If you can drop the non-existing Xu at freedesktop.org email that
> > >> would be even better.
> > > Sorry, it's due to my git configure, and I have solved it.
> > >
> > >>
> > >> Thanks
> > >> Emil
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > >
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev