[Mesa-dev] [PATCH 10/11] i965: Use aubinator/genxml for INTEL_DEBUG=bat commands.

[Jason Ekstrand]

On Mon, Mar 20, 2017 at 8:17 AM, Emil Velikov <emil.l.velikov at gmail.com>
wrote:

> On 20 March 2017 at 15:07, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
> > On 20/03/17 12:14, Emil Velikov wrote:
> >>
> >> On 20 March 2017 at 09:13, Kenneth Graunke <kenneth at whitecape.org>
> wrote:
> >>>
> >>> This should give substantially better decoding, as the public libdrm
> >>> decoder hasn't been properly maintained in years.
> >>>
> >>> For now, we reuse the existing state dumping mechanism.  We'll improve
> >>> that in the next patch.
> >>
> >> Can you share the size of i965_dri.so before/after this patch/series ?
> >> I'd imagine that things will be noticeably larger since we the,
> >> thankfully zlib[ed], _xml.h files are within the final binary.
> >> That in itself is _not_ a blocker, but good to point out, since it's
> >> not obvious.
> >
> >
> > I measured an 8k increase, which seems fine to me for now.
> > Since this will increase for every new generation, I'll investigate a
> > mechanism to share the common data we have in different files.
> > Maybe moving away from xml to get store the data in our binary.
>

Deduplication?  That sounds like a good job for a compression library. :-)
Maybe we can just store all of the XML together in some sort of a gziped
tarball so that zlib can see all of them at the same time and dedup.  I
wouldn't spend much time on it though.


> >
> Nice - that's a lot less than i expected.
>
> Can we please have some before/after numbers in the commit log ?
> Personally I wouldn't bother 'optimising'/reworking it anytime soon,
> since zlib [seemingly] does a pretty good job at compressing the XML
> files ;-)
>

+1 for not bothering to make it any better right now.  8KB is tiny in a 12
MB driver.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170320/cec2bd58/attachment.html>