[Mesa-dev] [PATCH 003/140] amdgpu/addrlib: allow tileSplitBytes greater than row size

Marek Olšák maraeo at gmail.com
Mon Mar 20 22:42:13 UTC 2017


From: Xiao-Tao Zai <xaio-tao.zai at amd.com>

Carrizo row size is 1K, while tileSplitBytes is 2K for a 4xAA 32bpp
depth surface. Remove the sanity check that tileSplitBytes must be
greater than row size. There could be performance loss but may be
covered by non-split depth which enables tc-compatible read.
---
 src/amd/addrlib/r800/egbaddrlib.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/addrlib/r800/egbaddrlib.cpp b/src/amd/addrlib/r800/egbaddrlib.cpp
index e534798..abd1a79 100644
--- a/src/amd/addrlib/r800/egbaddrlib.cpp
+++ b/src/amd/addrlib/r800/egbaddrlib.cpp
@@ -987,21 +987,21 @@ BOOL_32 EgBasedAddrLib::SanityCheckMacroTiled(
         {
             // This will generate macro tile height <= 1
             valid = FALSE;
         }
     }
 
     if (valid)
     {
         if (pTileInfo->tileSplitBytes > m_rowSize)
         {
-            valid = FALSE;
+            ADDR_WARN(0, ("tileSplitBytes is bigger than row size"));
         }
     }
 
     if (valid)
     {
         valid = HwlSanityCheckMacroTiled(pTileInfo);
     }
 
     ADDR_ASSERT(valid == TRUE);
 
-- 
2.7.4



More information about the mesa-dev mailing list