[Mesa-dev] [PATCH 6/5] i965: Turn on support for image modifiers

[Jason Ekstrand]

On Mon, Mar 20, 2017 at 4:15 PM, Ben Widawsky <ben at bwidawsk.net> wrote:

> On 17-03-20 12:03:24, Jason Ekstrand wrote:
>
>> My only question here is whether or not we want to add a "supported
>> modifiers" query to DRIimage before we bump the version number.  It's
>> probably not super-important because we can always bump the version number
>> again.  Meh.
>>
>>
> Remind me what the reasoning is for support modifiers? I thought we agreed
> to
> just use GET_PLANE2? Supported modifiers is difficult because mesa has no
> idea
> of per plane constraints.


They're for completely different cases.  If you want to scan out, use
GET_PLANE2, end of story.  If, however, you're not trying to scan out and
your window is always going to get composited (think not full-screen) then
you may have a much larger set of modifiers available to you and that set
of modifiers is not determined by GET_PLANE2 but by the GL or whatever is
being used for compositing.


>
> On Sat, Mar 18, 2017 at 1:00 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
>>
>> All the plumbing is in place so the extension just needs to be
>>> advertised.
>>>
>>> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
>>> ---
>>>  src/mesa/drivers/dri/i965/intel_screen.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/mesa/drivers/dri/i965/intel_screen.c
>>> b/src/mesa/drivers/dri/i965/intel_screen.c
>>> index ca725d9202..1ff18b30e4 100644
>>> --- a/src/mesa/drivers/dri/i965/intel_screen.c
>>> +++ b/src/mesa/drivers/dri/i965/intel_screen.c
>>> @@ -948,7 +948,7 @@ intel_from_planar(__DRIimage *parent, int plane, void
>>> *loaderPrivate)
>>>  }
>>>
>>>  static const __DRIimageExtension intelImageExtension = {
>>> -    .base = { __DRI_IMAGE, 13 },
>>> +    .base = { __DRI_IMAGE, 14 },
>>>
>>>      .createImageFromName                = intel_create_image_from_name,
>>>      .createImageFromRenderbuffer        = intel_create_image_from_
>>> renderbuffer,
>>> --
>>> 2.12.0
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>>
>>>
> --
> Ben Widawsky, Intel Open Source Technology Center
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170320/771cca22/attachment.html>