[Mesa-dev] [PATCH 1/2] anv: automake: use the local headers over any system provided ones

Grazvydas Ignotas notasas at gmail.com
Tue Mar 21 18:58:25 UTC 2017


On Tue, Mar 21, 2017 at 2:05 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 20 March 2017 at 21:51, Jason Ekstrand <jason at jlekstrand.net> wrote:
>> On Mon, Mar 20, 2017 at 8:18 AM, Emil Velikov <emil.l.velikov at gmail.com>
>> wrote:
>>> diff --git a/src/intel/Makefile.vulkan.am b/src/intel/Makefile.vulkan.am
>>> index 185780246e2..7aacdf4e094 100644
>>> --- a/src/intel/Makefile.vulkan.am
>>> +++ b/src/intel/Makefile.vulkan.am
>>> @@ -85,6 +85,7 @@ VULKAN_CFLAGS = \
>>>         -msse2
>>>
>>>  VULKAN_CPPFLAGS = \
>>> +       $(AM_CPPFLAGS) \
>>>         -I$(top_srcdir)/src/compiler \
>>>         -I$(top_srcdir)/src/intel/compiler \
>>>         -I$(top_builddir)/src/intel/vulkan \
>>> @@ -92,8 +93,7 @@ VULKAN_CPPFLAGS = \
>>>         -I$(top_srcdir)/src/vulkan/wsi \
>>>         -I$(top_builddir)/src/vulkan/util \
>>>         -I$(top_srcdir)/src/vulkan/util \
>>> -       $(LIBDRM_CFLAGS) \
>>> -       $(AM_CPPFLAGS)
>>> +       $(LIBDRM_CFLAGS)
>>
>>
>> Why can't we just flip AM_CPPFLAGS and LIBDRM_CPPFLAGS?
>>
> Seems like a po-tay-to po-tah-to case. Since Grazvydas also asked for
> this, I fixed it up and pushed the patches.

Somehow I don't see them in git.

GraÅžvydas


More information about the mesa-dev mailing list