[Mesa-dev] [PATCH] anv/device: Move push descriptor query handling

[Lionel Landwerlin]

Thanks!

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 21/03/17 21:37, Jason Ekstrand wrote:
> The query is a properties query so it needs to be handled in
> GetPhysicalDeviceProperties2, not GetPhysicalDeviceFeatures2.
>
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>   src/intel/vulkan/anv_device.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 74aad45..bbf7a38 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -513,14 +513,6 @@ void anv_GetPhysicalDeviceFeatures2KHR(
>   
>      vk_foreach_struct(ext, pFeatures->pNext) {
>         switch (ext->sType) {
> -      case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PUSH_DESCRIPTOR_PROPERTIES_KHR: {
> -         VkPhysicalDevicePushDescriptorPropertiesKHR *properties =
> -            (VkPhysicalDevicePushDescriptorPropertiesKHR *) ext;
> -
> -         properties->maxPushDescriptors = MAX_PUSH_DESCRIPTORS;
> -         break;
> -      }
> -
>         default:
>            anv_debug_ignored_stype(ext->sType);
>            break;
> @@ -677,6 +669,14 @@ void anv_GetPhysicalDeviceProperties2KHR(
>   
>      vk_foreach_struct(ext, pProperties->pNext) {
>         switch (ext->sType) {
> +      case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PUSH_DESCRIPTOR_PROPERTIES_KHR: {
> +         VkPhysicalDevicePushDescriptorPropertiesKHR *properties =
> +            (VkPhysicalDevicePushDescriptorPropertiesKHR *) ext;
> +
> +         properties->maxPushDescriptors = MAX_PUSH_DESCRIPTORS;
> +         break;
> +      }
> +
>         default:
>            anv_debug_ignored_stype(ext->sType);
>            break;