[Mesa-dev] [PATCH] anv: remove spec quote from anv_EnumeratePhysicalDevices

Emil Velikov emil.l.velikov at gmail.com
Wed Mar 22 15:50:03 UTC 2017


On 15 February 2017 at 16:25, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> The VK_SUCCESS/VK_INCOMPLETE pattern is quite common.
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Based on top of the drmGetDevice2 series sent earlier.
>
>  src/intel/vulkan/anv_device.c | 17 -----------------
>  1 file changed, 17 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index d804963cce..137f7fdd64 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -437,23 +437,6 @@ VkResult anv_EnumeratePhysicalDevices(
>           return result;
>     }
>
> -   /* pPhysicalDeviceCount is an out parameter if pPhysicalDevices is NULL;
> -    * otherwise it's an inout parameter.
> -    *
> -    * The Vulkan spec (git aaed022) says:
> -    *
> -    *    pPhysicalDeviceCount is a pointer to an unsigned integer variable
> -    *    that is initialized with the number of devices the application is
> -    *    prepared to receive handles to. pname:pPhysicalDevices is pointer to
> -    *    an array of at least this many VkPhysicalDevice handles [...].
> -    *
> -    *    Upon success, if pPhysicalDevices is NULL, vkEnumeratePhysicalDevices
> -    *    overwrites the contents of the variable pointed to by
> -    *    pPhysicalDeviceCount with the number of physical devices in in the
> -    *    instance; otherwise, vkEnumeratePhysicalDevices overwrites
> -    *    pPhysicalDeviceCount with the number of physical handles written to
> -    *    pPhysicalDevices.
> -    */
>     if (!pPhysicalDevices) {
>        *pPhysicalDeviceCount = instance->physicalDeviceCount;
>     } else if (*pPhysicalDeviceCount >= 1) {
> --
Any takers on this trivial patch ?

Thanks
Emil


More information about the mesa-dev mailing list