[Mesa-dev] [PATCH 2/4] si_compute: check NULL return from u_upload_alloc

Marek Olšák maraeo at gmail.com
Fri Mar 24 15:32:52 UTC 2017


I think we should also return from si_launch_grid if this fails.

Marek

On Fri, Mar 24, 2017 at 12:08 PM, Julien Isorce <julien.isorce at gmail.com> wrote:
> Signed-off-by: Julien Isorce <jisorce at oblong.com>
> ---
>  src/gallium/drivers/radeonsi/si_compute.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c
> index 19a9189..e3ccc55 100644
> --- a/src/gallium/drivers/radeonsi/si_compute.c
> +++ b/src/gallium/drivers/radeonsi/si_compute.c
> @@ -602,6 +602,9 @@ static void si_upload_compute_input(struct si_context *sctx,
>                        &kernel_args_offset,
>                        (struct pipe_resource**)&input_buffer, &kernel_args_ptr);
>
> +       if (unlikely(!kernel_args_ptr))
> +               return;
> +
>         kernel_args = (uint32_t*)kernel_args_ptr;
>         kernel_args_va = input_buffer->gpu_address + kernel_args_offset;
>
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list