[Mesa-dev] [PATCH 6/9] isl: Validate the calculated row pitch (v2)

[Emil Velikov]

Hi Chad,

On 23 March 2017 at 01:04, Chad Versace <chadversary at chromium.org> wrote:
> Validate that isl_surf::row_pitch fits in the below bitfields,
> if applicable based on isl_surf::usage.
>
>     RENDER_SURFACE_STATE::SurfacePitch
>     RENDER_SURFACE_STATE::AuxiliarySurfacePitch
>     3DSTATE_DEPTH_BUFFER::SurfacePitch
>     3DSTATE_HIER_DEPTH_BUFFER::SurfacePitch
>
> v2: Add a Makefile dependency on generated header genX_bits.h.
> ---
>  src/intel/Makefile.isl.am |  3 ++
>  src/intel/isl/isl.c       | 72 +++++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 69 insertions(+), 6 deletions(-)
>
> diff --git a/src/intel/Makefile.isl.am b/src/intel/Makefile.isl.am
> index ee2215df1d1..09a10281b45 100644
> --- a/src/intel/Makefile.isl.am
> +++ b/src/intel/Makefile.isl.am
> @@ -63,6 +63,9 @@ isl/isl_format_layout.c: isl/gen_format_layout.py \
>         $(PYTHON_GEN) $(srcdir)/isl/gen_format_layout.py \
>             --csv $(srcdir)/isl/isl_format_layout.csv --out $@
>
> +# Dependencies on generated files
> +$(builddir)/isl/isl.o: $(srcdir)/genxml/genX_bits.h
> +
Can we have this as below. We could also squash it with 3/9.

BUILT_SOURCES += genxml/genX_bits.h
EXTRA_DIST += genxml/genX_bits.h

Thanks
Emil