[Mesa-dev] [PATCH v2] mesa/main: Fix memset in formatquery.c
Edward O'Callaghan
funfunctor at folklore1984.net
Sun Mar 26 23:51:50 UTC 2017
V.1:
We memset number of elements without multiplication by the
element size.
V.2:
We explicitly set each member to -1 over using a confusing
memset().
Signed-off-by: Edward O'Callaghan <funfunctor at folklore1984.net>
---
src/mesa/main/formatquery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c
index 598d34d..6aa57ec 100644
--- a/src/mesa/main/formatquery.c
+++ b/src/mesa/main/formatquery.c
@@ -1564,7 +1564,7 @@ _mesa_GetInternalformati64v(GLenum target, GLenum internalformat,
* no pname can return a negative value, we fill params32 with negative
* values as reference values, that can be used to know what copy-back to
* params */
- memset(params32, -1, 16);
+ for (i = 0; i < realSize; i++) params32[i] = -1;
/* For GL_MAX_COMBINED_DIMENSIONS we need to get back 2 32-bit integers,
* and at the same time we only need 2. So for that pname, we call the
--
2.9.3
More information about the mesa-dev
mailing list