[Mesa-dev] [PATCH] anv: bump push constant max size to 512bytes

[Eduardo Lima Mitev]

We have hit this limit too while working on an upcoming Vulkan
extension. Increasing the push constants area to 512 seems sensible and
safe. I also checked on CI that this brings no regressions.

This patch needs a trivial rebase fix, otherwise it is:

Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>

On 12/02/2016 03:38 PM, Lionel Landwerlin wrote:
> This is the size selected by the i965 driver.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/intel/vulkan/anv_private.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
> index 1f03b68..ce4eb4d 100644
> --- a/src/intel/vulkan/anv_private.h
> +++ b/src/intel/vulkan/anv_private.h
> @@ -77,7 +77,7 @@ extern "C" {
>  #define MAX_RTS          8
>  #define MAX_VIEWPORTS   16
>  #define MAX_SCISSORS    16
> -#define MAX_PUSH_CONSTANTS_SIZE 128
> +#define MAX_PUSH_CONSTANTS_SIZE (4 * 8 * 16) /* 16 (256-bits) registers */
>  #define MAX_DYNAMIC_BUFFERS 16
>  #define MAX_IMAGES 8
>  #define MAX_SAMPLES_LOG2 4 /* SKL supports 16 samples */
>