[Mesa-dev] [PATCH kmscube 2/3] add video cube

Rob Clark robdclark at gmail.com
Mon Mar 27 14:01:46 UTC 2017


On Mon, Mar 27, 2017 at 5:41 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>
>> +               dec->egl->eglDestroyImageKHR(dec->egl->display, dec->last_frame);
>
> Unrelated: we must be using glGetString(GL_EXTENSIONS) and
> eglQueryString(... EGL_EXTENSIONS) alongside eglGetProcAddress().
> It's not cool that kmscube does not follow the documentation :-\


admittedly, I initially intentionally skipped this, to reduce the
noise (since kmscube is supposed to be just some simple toy code)..  I
guess it's grown enough features that this argument doesn't really
hold anymore.  I'll think about adding some checks as a follow-on
patch.

BR,
-R


More information about the mesa-dev mailing list