[Mesa-dev] [PATCH 3/3] mesa/main: Reduce the size of nr_enabled_units in ff cache key.

Eric Anholt eric at anholt.net
Mon Mar 27 20:18:29 UTC 2017


Gustaw Smolarczyk <wielkiegie at gmail.com> writes:

> Since it holds values from 0 to 8, 4 bits will suffice.
>
> Signed-off-by: Gustaw Smolarczyk <wielkiegie at gmail.com>

I don't think this one will actually affect the size, since we're going
From 27 to 23 bits before the array of structs.

However, these changes all look good to me.  Series is:

Reviewed-by: Eric Anholt <eric at anholt.net>

I think that moving the cache key to the context is a really good idea.
Back when I did this work, we still had non-shader-based hardware as a
significant concern, but I don't think we particularly care about
optimizing for those any more.  They could just maintain the ff state
key and as statechanges happen but never consume it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170327/f46f960c/attachment.sig>


More information about the mesa-dev mailing list