[Mesa-dev] [Mesa-stable] [PATCH] radv: Reduce number of max descriptor sets to 4.

[Bas Nieuwenhuizen]

On Tue, Mar 28, 2017 at 4:12 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 17 March 2017 at 08:42, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl> wrote:
>> We never supported more, as we can run out of user SGPRs on the VS.
>>
>> Fixes: f4e499ec791 ("radv: add initial non-conformant radv vulkan driver")
>> Signed-off-by: Bas Nieuwenhuizen <basni at google.com>
>> CC: <mesa-stable at lists.freedesktop.org>
>> CC: James Legg <jlegg at feralinteractive.com>
>> ---
>>  src/amd/vulkan/radv_descriptor_set.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/amd/vulkan/radv_descriptor_set.h b/src/amd/vulkan/radv_descriptor_set.h
>> index c373489ccb3..d512fbdd51a 100644
>> --- a/src/amd/vulkan/radv_descriptor_set.h
>> +++ b/src/amd/vulkan/radv_descriptor_set.h
>> @@ -26,7 +26,7 @@
>>
>>  #include <vulkan/vulkan.h>
>>
>> -#define MAX_SETS         8
>> +#define MAX_SETS         4
>>
> FTR, seems like the patch was superseded by the one below.
> Please let me know if that's not the case and we need it in stable.

The issue contained in this patch is still present, but given that it
is only a corner case that is unlikely to be hit,  somewhat reduced
exposed capabilities and lack of interest from reviewers I'm going to
let it rest.

Thanks for inquiring,
Bas

>
> commit e88cac1df03d01a9e8a1de1a4a2ee888149e727a
> Author: James Legg <jlegg at feralinteractive.com>
> Date:   Thu Mar 16 17:48:13 2017 +0000
>
>     radv: Fix using more than 4 bound descriptor sets
>
>
>
> Thanks
> Emil