[Mesa-dev] [PATCH] i965: Use WARN_ONCE instead of open coding it.

Jason Ekstrand jason at jlekstrand.net
Wed Mar 29 05:42:00 UTC 2017


Rb


On March 28, 2017 21:51:06 Kenneth Graunke <kenneth at whitecape.org> wrote:

> ---
>  src/mesa/drivers/dri/i965/brw_compute.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_compute.c 
> b/src/mesa/drivers/dri/i965/brw_compute.c
> index 16b5df7ca4e..21da2ad17b5 100644
> --- a/src/mesa/drivers/dri/i965/brw_compute.c
> +++ b/src/mesa/drivers/dri/i965/brw_compute.c
> @@ -219,15 +219,10 @@ brw_dispatch_compute_common(struct gl_context *ctx)
>           fail_next = true;
>           goto retry;
>        } else {
> -         if (intel_batchbuffer_flush(brw) == -ENOSPC) {
> -            static bool warned = false;
> -
> -            if (!warned) {
> -               fprintf(stderr, "i965: Single compute shader dispatch "
> -                       "exceeded available aperture space\n");
> -               warned = true;
> -            }
> -         }
> +         int ret = intel_batchbuffer_flush(brw);
> +         WARN_ONCE(ret == -ENOSPC,
> +                   "i965: Single compute shader dispatch "
> +                   "exceeded available aperture space\n");
>        }
>     }
>
> --
> 2.12.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev




More information about the mesa-dev mailing list