[Mesa-dev] [PATCH 000/140] RadeonSI: Initial Vega10 support

Marek Olšák maraeo at gmail.com
Thu Mar 30 15:10:21 UTC 2017


On Thu, Mar 30, 2017 at 4:02 PM, Mike Lothian <mike at fireburn.co.uk> wrote:
> I get warnings with patch 058/140
>
> /var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h:39:7:
> warning: type 'union GB_ADDR_CONFIG' violates the C++ One Definition Rule
> [-Wodr]
>  union GB_ADDR_CONFIG {
>        ^
> /var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/r800/si_gb_reg.h:92:3:
> note: a different type is defined in another translation unit
>  } GB_ADDR_CONFIG;
>    ^
> /var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h:74:7:
> note: the first difference of corresponding definitions is field 'bitfields'
>      } bitfields, bits;
>        ^
> /var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/r800/si_gb_reg.h:90:25:
> note: a field with different name is defined in another translation unit
>       unsigned int val : 32;

If the definitions are unused, we can just remove them. Patches welcome.

Marek


More information about the mesa-dev mailing list