[Mesa-dev] [PATCH v2 05/18] anv: Implement VK_KHX_external_memory_capabilities

Chad Versace chadversary at chromium.org
Thu Mar 30 18:22:07 UTC 2017


On Mon 13 Mar 2017, Jason Ekstrand wrote:
> From: Chad Versace <chadversary at chromium.org>
> 
> This is a complete but trivial implementation. It's trivial becasue We
> support no external memory capabilities yet.  Most of the real work in
> this commit is in reworking the UUIDs advertised by the driver.
> 
> v2 (chadv):
>   - Fix chain traversal in vkGetPhysicalDeviceImageFormatProperties2KHR.
>     Extract VkPhysicalDeviceExternalImageFormatInfoKHX from the chain of
>     input structs, not the chain of output structs.
>   - In vkGetPhysicalDeviceImageFormatProperties2KHR, iterate over the
>     input chain and the output chain separately. Reduces diff in future
>     dma_buf patches.
> 
> Co-authored-with: Jason Ekstrand <jason.ekstrand at intel.com>
> ---
>  src/intel/vulkan/anv_device.c           | 53 ++++++++++++++++++++---
>  src/intel/vulkan/anv_entrypoints_gen.py |  1 +
>  src/intel/vulkan/anv_formats.c          | 75 +++++++++++++++++++++++++++++----
>  src/intel/vulkan/anv_private.h          |  2 +
>  4 files changed, 117 insertions(+), 14 deletions(-)


> +    * some bits if ISL info to ensure that this is safe.
                  ^^^
Typo: s/if/of/

With that, this patch is
Reviewed-by: Chad Versace <chadversary at chromium.org>


More information about the mesa-dev mailing list