[Mesa-dev] [PATCH v2 06/18] anv: Implement VK_KHX_external_memory

[Jason Ekstrand]

On Thu, Mar 30, 2017 at 11:27 AM, Chad Versace <chadversary at chromium.org>
wrote:

> On Mon 13 Mar 2017, Jason Ekstrand wrote:
> > There's really nothing for us to do here.  So long as the user doesn't
> > set any crazy environment variables such as INTEL_VK_HIZ=false, all of
> > the compression formats etc. should "just work" at least for opaque
> > handle types.
>
> I think the commit message should go with the opaque fd commit. This
> patch's commit message should say something like,
>
>   Turn it on. Trivially correct. Don't support any
> VkExternalMemoryHandleTypes yet.
>

Good call.  I wrote:

    This is the trivial implementation that just exposes the extension
    string but exposes zero external handle types.

I moved the other comment to the external_memory_fd commit.


> but in real sentences ;)
>
> > ---
> >  src/intel/vulkan/anv_device.c           | 6 +++++-
> >  src/intel/vulkan/anv_entrypoints_gen.py | 1 +
> >  2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/intel/vulkan/anv_device.c
> b/src/intel/vulkan/anv_device.c
> > index f92a313..385a806 100644
> > --- a/src/intel/vulkan/anv_device.c
> > +++ b/src/intel/vulkan/anv_device.c
> > @@ -314,7 +314,11 @@ static const VkExtensionProperties
> device_extensions[] = {
> >     {
> >        .extensionName = VK_KHR_DESCRIPTOR_UPDATE_
> TEMPLATE_EXTENSION_NAME,
> >        .specVersion = 1,
> > -   }
> > +   },
> > +   {
> > +      .extensionName = VK_KHX_EXTERNAL_MEMORY_EXTENSION_NAME,
> > +      .specVersion = 1,
> > +   },
> >  };
> >
> >  static void *
> > diff --git a/src/intel/vulkan/anv_entrypoints_gen.py
> b/src/intel/vulkan/anv_entrypoints_gen.py
> > index 2c084ae..e8cdfb7 100644
> > --- a/src/intel/vulkan/anv_entrypoints_gen.py
> > +++ b/src/intel/vulkan/anv_entrypoints_gen.py
> > @@ -39,6 +39,7 @@ supported_extensions = [
> >     'VK_KHR_wayland_surface',
> >     'VK_KHR_xcb_surface',
> >     'VK_KHR_xlib_surface',
> > +   'VK_KHX_external_memory',
> >     'VK_KHX_external_memory_capabilities',
> >  ]
> >
> > --
> > 2.5.0.400.gff86faf
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170330/e9398dd5/attachment.html>