[Mesa-dev] [PATCH v2 2/6] mesa: Add support for GL_NV_fill_rectangle

Ilia Mirkin imirkin at alum.mit.edu
Thu Mar 30 23:22:25 UTC 2017


On Thu, Mar 30, 2017 at 5:40 PM, Lyude <lyude at redhat.com> wrote:
> +   /* From the GL_NV_fill_rectangle spec:
> +    *
> +    * "An INVALID_OPERATION error is generated by Begin or any Draw command if
> +    *  only one of the front and back polygon mode is FILL_RECTANGLE_NV."
> +    */
> +   if ((ctx->Polygon.FrontMode == GL_FILL_RECTANGLE_NV) !=
> +       (ctx->Polygon.BackMode == GL_FILL_RECTANGLE_NV)) {
> +      _mesa_error(ctx, GL_INVALID_OPERATION,
> +                  "GL_NV_fill_rectangle can only be used on both the front "

That should probably say "GL_FILL_RECTANGLE_NV must be used as both
front/back polygon mode or neither".

> +                  "and back polygon mode, not one or the other");
> +      return GL_FALSE;
> +   }


More information about the mesa-dev mailing list