[Mesa-dev] [PATCH 10/12] Android: default to building all drivers

[Emil Velikov]

On 27 April 2017 at 20:43, Rob Herring <robh at kernel.org> wrote:
> If BOARD_GPU_DRIVERS is empty, build all the drivers. This doesn't
> enable building mesa as that is controlled by including libGLES_mesa in
> the product.
>
> Signed-off-by: Rob Herring <robh at kernel.org>
> ---
>  Android.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Android.mk b/Android.mk
> index 9f481ee7e109..76858c1616bc 100644
> --- a/Android.mk
> +++ b/Android.mk
> @@ -1,3 +1,4 @@
> +
Spurious change?

>  # Mesa 3-D graphics library
>  #
>  # Copyright (C) 2010-2011 Chia-I Wu <olvaffe at gmail.com>
> @@ -53,8 +54,15 @@ gallium_drivers := \
>         vc4.HAVE_GALLIUM_VC4 \
>         virgl.HAVE_GALLIUM_VIRGL
>
> +$(warning $(BOARD_GPU_DRIVERS))
> +
Won't this cause a warning regardless of the contents of BOARD_GPU_DRIVERS?

> +ifeq ($(BOARD_GPU_DRIVERS),all)
Please add a bit of the commit message in here.

Thanks
Emil