[Mesa-dev] [PATCH] i965: Solve Android native fence fd double close issue

[Chad Versace]

On Sat 29 Apr 2017, Xu, Randy wrote:
> > -----Original Message-----
> > From: Emil Velikov [mailto:emil.l.velikov at gmail.com]
> > Sent: Saturday, April 29, 2017 8:36 PM
> > To: Chad Versace <chadversary at chromium.org>; Emil Velikov
> > <emil.l.velikov at gmail.com>; Xu, Randy <randy.xu at intel.com>; mesa-
> > dev at lists.freedesktop.org
> > Subject: Re: [Mesa-dev] [PATCH] i965: Solve Android native fence fd double
> > close issue
> > 
> > On 28 April 2017 at 17:18, Chad Versace <chadversary at chromium.org>
> > wrote:


> > > Emil, how about one of us appends your extended commit message to
> > > Randy's, and then pushes?
> > >
> > Feel free to polish and push Chad.
> > 
> > Randy please don't forget to send a patch for dri_interface.h.
> 
> Thanks, Emil,  if create_fence_fd just transfer fd ownership to the driver, 
> not dup, we also need change dri2_dup_native_fence_fd, which should not
> keep the fd after calls get_fence_fd. It should be workable, but I need do
> more test.

I suspect that it may be possible to eliminate _EGLSync::SyncFd, and
store the fd only in the driver. That would eliminate any confusion
about the semantics of DRI's create_fence_fd.

> Chad, please help to polish my comments, or give me some suggestions.

Randy, the patch is pushed to master.