[Mesa-dev] [PATCH 06/12] Android: rework libelf dependencies

[Emil Velikov]

On 2 May 2017 at 19:01, Rob Herring <robh at kernel.org> wrote:
> On Sun, Apr 30, 2017 at 4:52 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> Hi Rob,
>>
>> On 27 April 2017 at 20:43, Rob Herring <robh at kernel.org> wrote:
>>
>>> --- a/src/gallium/targets/dri/Android.mk
>>> +++ b/src/gallium/targets/dri/Android.mk
>>> @@ -105,10 +105,9 @@ LOCAL_WHOLE_STATIC_LIBRARIES := \
>>>         libmesa_util \
>>>         libmesa_loader
>>>
>>> -LOCAL_STATIC_LIBRARIES :=
>>> +LOCAL_STATIC_LIBRARIES := libelf
>>>
>>>  ifeq ($(MESA_ENABLE_LLVM),true)
>>> -LOCAL_STATIC_LIBRARIES += libelf
>> AFAICT we don't require any headers here, plus libelf is used only by
>> the radeon drivers.
>>
>> Are you sure this hunk is required/correct?
>
> Required, no, but neither is making it conditional either. It's just
> to get rid of some of the conditionals.
>
Admirable goal, but please keep the conditional. As-is this will force
Android build build and link the library even when it's not needed.
Wasting both CPU cycles and storage.

Thanks
Emil