[Mesa-dev] [PATCH v3 31/32] glsl: teach lower_ubo_reference about samplers inside structures

Ilia Mirkin imirkin at alum.mit.edu
Thu May 4 13:04:27 UTC 2017


On Thu, May 4, 2017 at 8:45 AM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 02.05.2017 22:53, Samuel Pitoiset wrote:
>>
>> In a situation like:
>>
>> (tex vec4 (record_ref (var_ref f)  tex)  (constant vec2 (0.000000
>> 0.000000))  0 1 () )
>>
>> The sampler needs to be lowered, otherwise this ends up with
>> "ir_dereference_variable @ 0x229a100 specifies undeclared variable
>> `ubo_load_temp' @ 0x2290440"
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>
>
> I think this loses image format / memory qualifiers. That's unfortunately
> not very easy to test for, but can you make sure the qualifiers survive to
> the TGSI?

It's a texture op... what scenario are you thinking of?

  -ilia


More information about the mesa-dev mailing list