[Mesa-dev] [PATCH v2 02/14] Android: define required __STDC* macros as cflags

[Rob Herring]

On Thu, May 4, 2017 at 10:12 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 3 May 2017 at 20:35, Rob Herring <robh at kernel.org> wrote:
>> From: Mauro Rossi <issor.oruam at gmail.com>
>>
>> Necessary to fix the following radeonsi building errors:
>>
>> In file included from external/mesa/src/gallium/drivers/radeonsi/si_blit.c:24:
>> In file included from external/mesa/src/gallium/drivers/radeonsi/si_pipe.h:29:
>> In file included from external/mesa/src/gallium/drivers/radeonsi/si_shader.h:71:
>> In file included from external/llvm/include/llvm-c/Core.h:18:
>> In file included from external/llvm/include/llvm-c/ErrorHandling.h:17:
>> In file included from external/llvm/include/llvm-c/Types.h:17:
>> external/llvm/include/llvm/Support/DataTypes.h:49:3: error: "Must #define __STDC_LIMIT_MACROS before #including Support/DataTypes.h"
>>   ^
>> external/llvm/include/llvm/Support/DataTypes.h:53:3: error: "Must #define __STDC_CONSTANT_MACROS before "         "#including Support/DataTypes.h"
>>   ^
>> 2 errors generated.
>> ---
>>
>> Yeah, I know this is not liked. I haven't really followed what's needed
>> to fix it correctly. Just skip this one.
>>
> Any objections if I add the following before committing?
>
> # XXX: The following __STDC_*_MACROS defines should not be needed
> # It's likely due to a bug elsewhere, but let's temporarily add them
> here to fix the radeonsi build.

Fine by me.

Rob