[Mesa-dev] [PATCH 1/2] anv: fix anv_gem_mmap comment to not mention NULL

Samuel Iglesias Gonsálvez siglesias at igalia.com
Thu May 4 15:25:33 UTC 2017


Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

On Thu, 2017-05-04 at 15:55 +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> The function cannot return NULL, update the comment accordingly.
> 
> Fixes: b546c9d ("anv: anv_gem_mmap() returns MAP_FAILED as mapping
> error")
> Cc: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/intel/vulkan/anv_image.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/intel/vulkan/anv_image.c
> b/src/intel/vulkan/anv_image.c
> index 55402b25571..d21e055f020 100644
> --- a/src/intel/vulkan/anv_image.c
> +++ b/src/intel/vulkan/anv_image.c
> @@ -348,7 +348,7 @@ VkResult anv_BindImageMemory(
>     if (image->aux_surface.isl.size > 0) {
>  
>        /* The offset and size must be a multiple of 4K or else the
> -       * anv_gem_mmap call below will return NULL.
> +       * anv_gem_mmap call below will fail.
>         */
>        assert((image->offset + image->aux_surface.offset) % 4096 ==
> 0);
>        assert(image->aux_surface.isl.size % 4096 == 0);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170504/4b495125/attachment.sig>


More information about the mesa-dev mailing list