[Mesa-dev] [PATCH v2 00/14] Android build cleanup/fixes

Emil Velikov emil.l.velikov at gmail.com
Thu May 4 15:31:35 UTC 2017


On 3 May 2017 at 20:35, Rob Herring <robh at kernel.org> wrote:
> This is a series of clean-ups and fixes to the Android build files.
> Overall, it removes a lot of the if conditions that aren't necessary for
> normal builds and also enables "mmma external/mesa3d" to build
> everything for easier build testing.
>
> This fixes LLVM enabled builds on master though that requires changes
> to LLVM as well. In the process, LLVM builds with Lollipop are dropped
> as L doesn't have the minimum LLVM version for several drivers. Also,
> android-x86 L support is using mesa 11.0.
>
> I've only tested against AOSP master so far. Mauro tested M and N with
> the previous version of the series. I don't think there's anything
> really different here that would break M or N. A git branch including
> llvmpipe building is here[1].
>
> v2 highlights:
> - Rework handling of LLVM settings
> - Cleanup of libcxx includes
> - Clarify the "all" driver option
> - Make libelf a whole static lib
> - Warn on LLVM enabled on L or earlier
> - Various comments requested by Emil
>
Huge thanks for addressing my comments Rob! And hats off for going the
extra mile and fixing a couple of things I've missed in my review.

I'll give it a day or two for others to comment. Barring anything
serious I'll address any nitpick before pushing.
If anyone beats be to it, the series is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Cheers,
Emil


More information about the mesa-dev mailing list