[Mesa-dev] [PATCH 3/3] egl: Implement EGL_EXT_device_{base, query, enumeration}

[Eric Anholt]

Adam Jackson <ajax at redhat.com> writes:

> On Wed, 2017-05-03 at 12:38 -0700, Eric Anholt wrote:
>> > Adam Jackson <ajax at redhat.com> writes:
>> > +#ifdef HAVE_LIBDRM
>> > +/* XXX kind of copypasta of drmCompareBusInfo */
>> > +static int
>> > +dri2_bus_info_equal(drmDevicePtr a, drmDevicePtr b)
>> > +{
>> > +    if (a == NULL || b == NULL)
>> > +	return 0;
>> > +
>> > +    if (a->bustype != b->bustype)
>> > +	return 0;
>> > +
>> > +    if (a->bustype == DRM_BUS_PCI)
>> > +	return !memcmp(a->businfo.pci, b->businfo.pci, sizeof(drmPciBusInfo));
>> > +
>> > +    return 0;
>> > +}
>> > +#endif
>> 
>> Yeah, this looks like a worse version of drmCompareBusInfo().  Would you
>> be willing to export it from libdrm, instead?  If not, please re-copy it
>> to get the usb/platform/host1x bits.
>
> Apologies, I copied this bit at a time when it only had the PCI case
> anyway. libdrm patch sent. I may need some guidance about which
> LIBDRM_REQUIRED in configure is the one to bump.

Thanks for doing that.  I think it would just be the top level
LIBDRM_REQUIRED.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170504/c99f247a/attachment.sig>