[Mesa-dev] [PATCH 3/3] i965: Drop BRW_NEW_BLORP from 3DSTATE_VF atom.

Pohjolainen, Topi topi.pohjolainen at gmail.com
Fri May 5 08:59:03 UTC 2017


On Thu, May 04, 2017 at 08:13:07AM -0700, Kenneth Graunke wrote:
> BLORP doesn't program 3DSTATE_VF, since it doesn't use index buffers,
> making the setting irrelevant.  So there's no need to re-emit it after
> a BLORP operation - the old setting will still be in place.

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

Explanation in patch 2 also looks good to me. Lets wait for Emil
but you can add my r-b there.

> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index 70fca34e4fb..3156385c471 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -855,8 +855,7 @@ genX(upload_cut_index)(struct brw_context *brw)
>  const struct brw_tracked_state genX(cut_index) = {
>     .dirty = {
>        .mesa  = _NEW_TRANSFORM,
> -      .brw   = BRW_NEW_BLORP |
> -               BRW_NEW_INDEX_BUFFER,
> +      .brw   = BRW_NEW_INDEX_BUFFER,
>     },
>     .emit = genX(upload_cut_index),
>  };
> -- 
> 2.12.2
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list