[Mesa-dev] [PATCH] st/glsl_to_tgsi: don't use rzalloc_array() when it's unnecessary

[Timothy Arceri]

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 05/05/17 19:01, Samuel Pitoiset wrote:
> When the arrays are initialized later on with -1, that's useless
> to use rzalloc_array().
> 
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> index 81c1d00dfb..768db8a91e 100644
> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> @@ -5316,8 +5316,8 @@ glsl_to_tgsi_visitor::merge_two_dsts(void)
>   void
>   glsl_to_tgsi_visitor::merge_registers(void)
>   {
> -   int *last_reads = rzalloc_array(mem_ctx, int, this->next_temp);
> -   int *first_writes = rzalloc_array(mem_ctx, int, this->next_temp);
> +   int *last_reads = ralloc_array(mem_ctx, int, this->next_temp);
> +   int *first_writes = ralloc_array(mem_ctx, int, this->next_temp);
>      struct rename_reg_pair *renames = rzalloc_array(mem_ctx, struct rename_reg_pair, this->next_temp);
>      int i, j;
>      int num_renames = 0;
> @@ -6727,10 +6727,10 @@ get_mesa_program_tgsi(struct gl_context *ctx,
>       * optimization passes. */
>      {
>         int i;
> -      int *first_writes = rzalloc_array(v->mem_ctx, int, v->next_temp);
> -      int *first_reads = rzalloc_array(v->mem_ctx, int, v->next_temp);
> -      int *last_writes = rzalloc_array(v->mem_ctx, int, v->next_temp);
> -      int *last_reads = rzalloc_array(v->mem_ctx, int, v->next_temp);
> +      int *first_writes = ralloc_array(v->mem_ctx, int, v->next_temp);
> +      int *first_reads = ralloc_array(v->mem_ctx, int, v->next_temp);
> +      int *last_writes = ralloc_array(v->mem_ctx, int, v->next_temp);
> +      int *last_reads = ralloc_array(v->mem_ctx, int, v->next_temp);
>   
>         for (i = 0; i < v->next_temp; i++) {
>            first_writes[i] = -1;
>