[Mesa-dev] [PATCH 1/2] ac: fix broken elimination of duplicated VS exports

Marek Olšák maraeo at gmail.com
Mon May 8 17:17:55 UTC 2017


On Mon, May 8, 2017 at 7:00 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 08.05.2017 18:38, Marek Olšák wrote:
>>
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> The renumbering code didn't take into account that multiple VS exports
>> can have the same PARAM index. This also significantly simplifies
>> the renumbering. Thankfully, we have piglits for this:
>>
>>     spec at arb_gpu_shader5@arb_gpu_shader5-interpolateatcentroid-packing
>>     spec at glsl-1.50@execution at interface-blocks-complex-vs-fs
>>
>> Reported by Michel Dänzer.
>
>
> That does look cleaner.
>
> Fixes: b08715499e61 ("ac: eliminate duplicated VS exports")
> Cc: mesa-stable at lists.freedesktop.org
> Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>

Thanks. BTW, stable doesn't need this, because it's a fairly new
optimization committed 5 days ago.

Marek


More information about the mesa-dev mailing list