[Mesa-dev] [PATCH 2/2] st/mesa: use min_index and max_index directly from vbo

[Marek Olšák]

On Mon, May 8, 2017 at 7:58 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Mon, May 8, 2017 at 1:52 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> On Mon, May 8, 2017 at 7:28 PM, Rob Clark <robdclark at gmail.com> wrote:
>>> This commit breaks 'glmark2 -b ideas' on a3xx..  probably a2xx too.
>>> (a4xx/a5xx, and from the looks of it, radeon, ignore min/max_index..)
>>> Nouveau also uses min/max_index, so wouldn't be surprised if this commit
>>> causes problems there too..
>>>
>>> Any particular need for this commit, or can I push a revert?
>>
>> It shouldn't cause any issues since min/max_index should be 0 and ~0
>> in cases when they don't matter. Why do you need to use min/max_index
>> if you don't do legacy vertex uploads in the driver? Can you just use
>> 0, ~0 in the hw registers like radeonsi?
>
> It's necessary to prevent out-of-bounds reads on the VBO with invalid indices.

I know, but radeonsi doesn't need that, so I doubt nouveau does.

Marek