[Mesa-dev] [PATCH] mesa/vbo: fix invalid min/max indexes

Rob Clark robdclark at gmail.com
Mon May 8 21:50:51 UTC 2017


On Mon, May 8, 2017 at 5:29 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Mon, May 8, 2017 at 5:27 PM, Rob Clark <robdclark at gmail.com> wrote:
>> On Mon, May 8, 2017 at 4:57 PM, Marek Olšák <maraeo at gmail.com> wrote:
>>> I personally find the assertions unnecessary because the bug has been
>>> discovered and fixed by this patch, and this code is unlikely to
>>> change. Anyway:
>>>
>>> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>>
>> I don't suppose there is something like debug_assert() (ie. only
>> defined for --enable-debug builds) for mesa code?  That was really
>> what I wanted there.  Maybe I'll just put #ifdef DEBUG / #endif around
>> it..
>
> Yeah. It's called "assert" :)

oh, heh, yeah we are injecting -DNDEBUG=1 for non-debug builds.. so
I'll just leave it as-is

BR,
-R


More information about the mesa-dev mailing list