[Mesa-dev] [PATCH v3 0/4] Disable glthread if libX11 isn't thread-safe

[gregory hainaut]

On Tue, 09 May 2017 09:31:18 -0700
Eric Anholt <eric at anholt.net> wrote:

> Gregory Hainaut <gregory.hainaut at gmail.com> writes:
> 
> > On 5/8/17, Emil Velikov <emil.l.velikov at gmail.com> wrote:  
>  [...]  
> >
> > Hello Emil,
> >
> > Yes you're right. And potentially it can be back-ported to stable
> > branch. Besides it would allow to know which applications aren't X
> > thread safe. And potentially app owners can fix the issue too.
> >
> > By the way, I don't have commit access so feel free to push the series :)
> >
> > On 5/8/17, Eric Anholt <eric at anholt.net> wrote:  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
>  [...]  
> >
> > Hello Eric,
> >
> > Indeed I saw this behavior on Nouveau. I got a crash on
> > GetBuffersWithFormat on DRI2 but it was fine on DRI3. I still kept the
> > check on GLX/DRI3 because I don't know if we have a strong guarantee
> > that X11 is never used.  
> 
> I would be surprised if there was a path that hit X through GL calls as
> opposed to the window system, with DRI3.  GetBuffersWithFormat was the
> problem.

Tbh, I'm a noob. If you're sure, we can always return true for GLX/DRI3. Otherwise
I will put a comment that it is likely fine. Your call.