[Mesa-dev] [RFC] intel/isl: Rewrite gen7_choose_image_alignment_el

[Emil Velikov]

Hi Jason,

Humble unrelated question.

On 9 May 2017 at 18:00, Jason Ekstrand <jason at jlekstrand.net> wrote:

> +   if (isl_surf_usage_is_depth(info->usage)) {
> +      if (info->format == ISL_FORMAT_R16_UNORM) {
> +         return isl_extent3d(8, 4, 1);
> +      } else {
> +         return isl_extent3d(4, 4, 1);
> +      }
> +   } else if (isl_surf_usage_is_stencil(info->usage)) {
> +      return isl_extent3d(8, 8, 1);
> +   } else if (isl_format_is_compressed(info->format)) {
> +      /* Compressed formats all have alignment equal to block size. */
> +      return isl_extent3d(1, 1, 1);
> +   }

I've seen a handful of constructs like the above.. Is there any reason
to keep the extra else/curly brackets?
Something like the following reads a bit easier yet admittedly I'm not
the person to set the coding style in isl.

   if (isl_surf_usage_is_depth(info->usage)) {
      if (info->format == ISL_FORMAT_R16_UNORM)
         return isl_extent3d(8, 4, 1);

      return isl_extent3d(4, 4, 1);
   }

   if (isl_surf_usage_is_stencil(info->usage))
      return isl_extent3d(8, 8, 1);

    /* Compressed formats all have alignment equal to block size. */
    if (isl_format_is_compressed(info->format))
      return isl_extent3d(1, 1, 1);


Thanks
Emil
/me crosses fingers that he won't hijack/divert the thread