[Mesa-dev] [RFC] intel/isl: Rewrite gen7_choose_image_alignment_el

[Emil Velikov]

On 10 May 2017 at 16:38, Jason Ekstrand <jason at jlekstrand.net> wrote:
> On Wed, May 10, 2017 at 8:26 AM, Emil Velikov <emil.l.velikov at gmail.com>
> wrote:
>>
>> Hi Jason,
>>
>> Humble unrelated question.
>>
>> On 9 May 2017 at 18:00, Jason Ekstrand <jason at jlekstrand.net> wrote:
>>
>> > +   if (isl_surf_usage_is_depth(info->usage)) {
>> > +      if (info->format == ISL_FORMAT_R16_UNORM) {
>> > +         return isl_extent3d(8, 4, 1);
>> > +      } else {
>> > +         return isl_extent3d(4, 4, 1);
>> > +      }
>> > +   } else if (isl_surf_usage_is_stencil(info->usage)) {
>> > +      return isl_extent3d(8, 8, 1);
>> > +   } else if (isl_format_is_compressed(info->format)) {
>> > +      /* Compressed formats all have alignment equal to block size. */
>> > +      return isl_extent3d(1, 1, 1);
>> > +   }
>>
>> I've seen a handful of constructs like the above.. Is there any reason
>> to keep the extra else/curly brackets?
>> Something like the following reads a bit easier yet admittedly I'm not
>> the person to set the coding style in isl.
>
>
> Does it?
>
Indeed it does, I would not have bothered otherwise ;-)
It's a subjective topic and my contributions here are, ahem, limited,
so feel do ignore me.

Thanks
Emil