[Mesa-dev] [RFC] intel/isl: Rewrite gen7_choose_image_alignment_el

[Nanley Chery]

On Wed, May 10, 2017 at 09:14:06PM +0300, Pohjolainen, Topi wrote:
> On Tue, May 09, 2017 at 10:00:34AM -0700, Jason Ekstrand wrote:
> > The Ivy Bridge PRM provides a nice table that handles most of the
> > alignment cases in one place.  For standard color buffers we have a
> > little freedom of choice but for most depth, stencil and compressed it's
> > hard-coded.  Chad's original functions split halign and valign apart and
> > implemented them almost entirely based on restrictions and not the
> > table.  This makes things way more confusing than they need to be.  This
> > commit gets rid of the split and makes us implement the exact table
> > up-front.  If our surface isn't one of the ones in the table we then to
> > on to make real choices.
> > 
> > The only functional change here is that we now return a vertical
> > alignment of 8 for stencil because that's what the table says to do.
> > That change should probably go in it's own patch.
> > 
> > If people like this change, I'm happy to do the same refactoring for
> > gen6, gen8, and gen9.
> 
> Really nice, I'm in favor.
> 

Agreed. This is a nice clean up.