[Mesa-dev] [PATCH 0/6] Various fixes to integer GetUniform*()

Iago Toral Quiroga itoral at igalia.com
Thu May 11 11:10:15 UTC 2017


This series is an update on a previous patch by Ken that fixed
a CTS test but never got merged due to the mess with the CTS repositories
at that time, plus a number of additional fixes for recently added int64 paths.

Patch 1 fixes indentation.
Patch 2 is the original patch by Ken, only tha rebased and amended to support
conversions from 64-bit integer types.
Patch 3 is the same as patch 2, but for 64-bit integer.
Patches 4-6 are two fixes for 64-bit integer conversion paths.

Ken: the release tarball in the khronos page still links to the old test suite
from 2016, however, it seems that it should be possible to send submissions from
the new repository as well (see [1]). I think we only want to commit patches
2-3 if we intend to use the new repository for any future submissions and maybe
we are not ready to make that decision yet. In that case we can skip patches 2-3
for now, at least we would habe them updated in the list for future reference,
however, I think we want to land the other patche ( although they would need a
minor update to avoid any uint clamping in case that we decide against landing
patches 2-3; I could re-send the series with only those patches in that case).

[1] https://github.com/KhronosGroup/VK-GL-CTS/wiki/Creating-a-OpenGL-and-OpenGL-ES-Submission-Package

Iago Toral Quiroga (5):
  mesa/main: fix indentation in _mesa_get_uniform()
  mesa: Clamp GetUniformui64v values to be >= 0
  mesa/main: add IROUNDD64() helper
  mesa: Add conversion from double to uint64/int64 in GetUniform*i64v()
  mesa: conversion from float in GetUniformi64v require rounding to
    nearest

Kenneth Graunke (1):
  mesa: Clamp GetUniformuiv values to be >= 0

 src/mesa/main/imports.h         |   7 +
 src/mesa/main/uniform_query.cpp | 299 ++++++++++++++++++++++++++--------------
 2 files changed, 206 insertions(+), 100 deletions(-)

-- 
2.9.3



More information about the mesa-dev mailing list