[Mesa-dev] [PATCH] android: r600: fix libmesa_amd_common dependency

Emil Velikov emil.l.velikov at gmail.com
Thu May 11 11:28:22 UTC 2017


On 13 March 2017 at 13:10, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 11 March 2017 at 16:26, Mauro Rossi <issor.oruam at gmail.com> wrote:
>> 2017-03-08 17:44 GMT+01:00 Emil Velikov <emil.l.velikov at gmail.com>:
>>>
>>> On 5 March 2017 at 21:23, Mauro Rossi <issor.oruam at gmail.com> wrote:
>>> > Adding libmesa_amd_common dependency and exporting its headers,
>>> > avoids the following building error:
>>> >
>>> > external/mesa/src/gallium/drivers/r600/evergreen_compute.c:29:10: fatal
>>> > error: 'ac_binary.h' file not found
>>> >          ^
>>> > 1 error generated.
>>> >
>>> > Fixes: 3bbbb63 "automake: r600: radeonsi: correctly manage
>>> > libamd_common.la linking"
>>> > Fixes: 503fb13 "radeon/ac: switch to ac_shader_binary_config_start()"
>>>
>>> Thank you Mauro.
>>> I've applied a bit of polish and pushed to master.
>>>
>>> -Emil
>>
>>
>> Hi Emil,
>>
>> With your v2 change I'm getting this building error, while it was building
>> ok with the header export in libmesa_amd_common module.
>>
> Sounds like a bug elsewhere, since all the users of
> inlibmesa_amd_common already explicitly have the include.
>
Fairly sure that the issue should be resolved with RobH's series.
I'll push that in a second, but do let me know if things are still problematic.

-Emil


More information about the mesa-dev mailing list