[Mesa-dev] [PATCH 2/4] intel/isl: Refactor gen7_choose_image_alignment_el

Pohjolainen, Topi topi.pohjolainen at gmail.com
Thu May 11 14:09:57 UTC 2017


On Wed, May 10, 2017 at 02:30:30PM -0700, Jason Ekstrand wrote:
> The Ivy Bridge PRM provides a nice table that handles most of the
> alignment cases in one place.  For standard color buffers we have a
> little freedom of choice but for most depth, stencil and compressed it's
> hard-coded.  Chad's original functions split halign and valign apart and
> implemented them almost entirely based on restrictions and not the
> table.  This makes things way more confusing than they need to be.  This
> commit gets rid of the split and makes us implement the exact table
> up-front.  If our surface isn't one of the ones in the table we then to
> on to make real choices.

Oops, forgot: the last bit "then to on to make real choices". Did you really
mean that or something missing/extra? 


More information about the mesa-dev mailing list